feat: event debugging (WIP) #1726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 95.50% 95.47% -0.04%
==========================================
Files 92 92
Lines 5139 5235 +96
Branches 563 901 +338
==========================================
+ Hits 4908 4998 +90
- Misses 231 237 +6 ☔ View full report in Codecov by Sentry. |
mdjastrzebski
force-pushed
the
feat/event-debugging
branch
3 times, most recently
from
ec51869 to
81a631b
Compare
mdjastrzebski
force-pushed
the
feat/event-debugging
branch
from
81a631b to
ec9b076
Compare
mdjastrzebski
requested review from
pierrezimmermannbam,
AugustinLF and
MattAgn
|
Could you share your feedback on this potential new feature @pierrezimmermannbam @MattAgn @AugustinLF |
MattAgn
reviewed
Aug 18, 2025
| @@ -19,6 +19,11 @@ export type Config = { | |||
| * Otherwise `render` will default to concurrent rendering. | |||
| */ | |||
| concurrentRoot: boolean; | |||
|
|
|||
| /** | |||
| * Verbose logging for the library. | |||
There was a problem hiding this comment.
i would add what it helps log : user event and fire event issues (for now)
MattAgn
reviewed
Aug 18, 2025
| @@ -30,6 +35,7 @@ const defaultConfig: Config = { | |||
| asyncUtilTimeout: 1000, | |||
| defaultIncludeHiddenElements: false, | |||
| concurrentRoot: true, | |||
| debug: false, | |||
There was a problem hiding this comment.
imo true is a good default because otherwise i fear not many people will hear about it and remember to turn it on
do you see more advantages with false as default ?
MattAgn
approved these changes
Aug 18, 2025
|
This is gonna be so helpful to debug! ✅ |
mdjastrzebski
force-pushed
the
feat/event-debugging
branch
from
95845da to
fc93a55
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1717
Resolves #1718
Introduces (event) debugging mode that outputs information about event handles not being called due to disabled state, etc.
Details
Enabling:
configure({ debug: true }). Cannot be configured onrenderasfireEventanduserEventare independent modules, not returns fromrender.Fire Event:
fireEventcall.User Event:
To Do
userEventcall.Test plan